-
-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Add Empty Component #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wyMinLwin is attempting to deploy a commit to the 8bitcn Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughAdds a new 8‑bit Empty UI (presentational components), a docs/demo Next.js page with page-level metadata and usage examples, registry and public manifest entries, a nav item for the component, and an exported image metadata constant. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Browser
participant DocsPage as /app/docs/components/empty/page
participant EmptyComp as components/ui/8bit/empty
rect `#f6fbff`
Browser->>DocsPage: GET /docs/components/empty
DocsPage->>EmptyComp: import Empty components + metadata
DocsPage->>EmptyComp: render <Empty> with slots (Header, Media, Title, Description, Content)
EmptyComp-->>DocsPage: composed preview DOM
end
rect `#f0fff4`
DocsPage-->>Browser: deliver docs page with live preview, installation commands, and code snippets
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Potential attention points:
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
public/assets/8bitcn-empty-dark.pngis excluded by!**/*.pngpublic/assets/8bitcn-empty-light.pngis excluded by!**/*.png
📒 Files selected for processing (4)
app/docs/components/empty/page.tsx(1 hunks)components/ui/8bit/empty.tsx(1 hunks)config/nav-items.ts(1 hunks)lib/metadata.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
app/docs/components/empty/page.tsx (5)
lib/metadata.ts (1)
emptyMetaData(63-63)app/docs/components/copy-command-button.tsx (1)
CopyCommandButton(13-37)app/docs/components/open-in-v0-button.tsx (1)
OpenInV0Button(5-39)app/docs/components/installation-commands.tsx (1)
InstallationCommands(15-124)app/docs/components/code-snippet.tsx (1)
CodeSnippet(94-142)
components/ui/8bit/empty.tsx (1)
lib/utils.ts (1)
cn(4-6)
🔇 Additional comments (5)
lib/metadata.ts (1)
63-63: LGTM!The metadata export follows the established pattern and naming convention used by all other component metadata in this file.
app/docs/components/empty/page.tsx (2)
1-29: LGTM!The imports and metadata configuration are properly structured and follow the established pattern for component documentation pages.
31-119: Well-structured documentation page.The page component follows the established documentation pattern with a clear preview section, installation commands, and usage examples.
components/ui/8bit/empty.tsx (1)
119-126: LGTM!All components are properly exported and the export order is logical.
config/nav-items.ts (1)
82-86: LGTM!The navigation item addition follows the established pattern and is correctly configured with the
new: trueflag to highlight this as a new component. The placement in the array doesn't affect the final order since the components are sorted alphabetically on line 252.
|
Hey there! Thanks for this contribution! Sorry I don't know how I missed it. Please run Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
public/r/empty.json(1 hunks)public/r/registry.json(1 hunks)registry.json(1 hunks)
🔇 Additional comments (2)
registry.json (1)
1826-1839: Registry entry structure is sound.The "empty" component is properly registered with no dependencies, matching the pattern of other presentational 8-bit components like spinner and kbd.
public/r/registry.json (1)
1826-1839: Public registry entry mirrors main registry.The entry is consistent with registry.json, maintaining proper alignment across both registry files.
|
I have done adding registry and running |
|
@TheOrcDev I have done everything to be ready. Mentioned you in case you missed this time again. |
TheOrcDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! Thank you for this one!
feat: Add Empty Component (TheOrcDev#422) * feat: Add Empty Component * fix: remove unncessary code * refactor: Refactor issue in Empty * refactor: font props * chore: Empty Registry * refactor: change != to !==
* feat: Item Component * refactor: fix issues for item component * refactor: refactor item props * refactor: remove sperator from codebase * chore: resolved merge conflits feat: Add Empty Component (#422) * feat: Add Empty Component * fix: remove unncessary code * refactor: Refactor issue in Empty * refactor: font props * chore: Empty Registry * refactor: change != to !== * feat: Item Component * chore: resolved merge confilts
Empty Component
Added empty component for issue #418
Summary by CodeRabbit
New Features
Documentation
Chores